Fixed..... #486
Merged
Fixed..... #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lexis-t : Hi Alexey, Please review the changes so that I can merge the same into master branch. |
| @@ -139,8 +147,8 @@ public void onPictureTaken(byte[] data, Camera camera) { | |||
| } | |||
| bitmap.recycle(); | |||
| mPreviewActivity.finish(); | |||
|
|
|||
| } | |||
| mcameraActivity.finish(); | |||
There was a problem hiding this comment.
This is unneeded. mcameraActivity is same object as mPreviewActivity. You call finish() twice.
Removed the line - "mcameraActivity.finish();" Regarding higher values (Above max resolution limit) of desired height and width, its discussed to have nominal value for time being.
Released media player object.
|
@lexis-t : I have done the changes as suggested. Please review the same. |
|
@lexis-t : Since the changes has to be reflected in the current build, I am merging the same. |
rhtv43
added a commit
that referenced
this pull request
Feb 6, 2015
…ptureSound Merging the changes as per suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lexis-t :Please review the same...