BZ 1090448 - make the remote agent install UI more pretty

modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/admin/agent/install/RemoteAgentInstallView.java

@@ -137,12 +137,11 @@ public RemoteAgentInstallView(AgentInstall initialInfo, Type type) {
     protected void onInit() {
         super.onInit();
         Layout layout = new VLayout();
-        layout.setPadding(10);
-        HTMLFlow header = new HTMLFlow(MSG.view_remoteAgentInstall_connInfo());
-        header.setStyleName("headerItem");
-        header.setExtraSpace(5);
-        layout.addMember(header);
+        layout.setPadding(5);
+        layout.setMembersMargin(5);
         layout.addMember(getConnectionForm());
+        layout.setDefaultLayoutAlign(Alignment.CENTER);
+        layout.setLayoutAlign(Alignment.CENTER);
 
         if (this.showInstallButton) {
             agentConfigXmlUploadForm = createAgentConfigXmlUploadForm();
@@ -155,7 +154,7 @@ protected void onInit() {
             */
         }
 
-        header = new HTMLFlow("");
+        HTMLFlow header = new HTMLFlow("");
         header.setStyleName("headerItem");
         header.setExtraSpace(5);
         layout.addMember(header);
@@ -176,6 +175,10 @@ private DynamicForm getConnectionForm() {
         connectionForm.setWrapItemTitles(false);
         connectionForm.setColWidths("130", "450", "110");
         connectionForm.setExtraSpace(15);
+        connectionForm.setWidth(790);
+        connectionForm.setPadding(5);
+        connectionForm.setIsGroup(true);
+        connectionForm.setGroupTitle(MSG.view_remoteAgentInstall_connInfo());
         final int textFieldWidth = 440;
 
         TextItem host = new TextItem("host", MSG.common_title_host());
@@ -385,9 +388,13 @@ private void displayMessage(String msg) {
     }
 
     private FileUploadForm createAgentConfigXmlUploadForm() {
-        final FileUploadForm uploadForm = new FileUploadForm("agent-configuration.xml", "1", true, true, null, true);
+        final FileUploadForm uploadForm = new FileUploadForm("agent-configuration.xml", "1", false, true, null, true);
         uploadForm.setCustomTooltipMessage(MSG.view_remoteAgentInstall_promptAgentConfigXml());
-        uploadForm.setWidth100();
+        uploadForm.setAutoWidth();
+        uploadForm.setPadding(5);
+        uploadForm.setIsGroup(true);
+        uploadForm.setGroupTitle("agent-configuration.xml");
+
         uploadForm.addFormHandler(new DynamicFormHandler() {
             @Override
             public void onSubmitComplete(DynamicFormSubmitCompleteEvent event) {
@@ -403,9 +410,12 @@ public void onSubmitComplete(DynamicFormSubmitCompleteEvent event) {
     }
 
     private FileUploadForm createAgentEnvUploadForm() {
-        final FileUploadForm uploadForm = new FileUploadForm("rhq-agent-env.sh", "1", true, true, null, true);
+        final FileUploadForm uploadForm = new FileUploadForm("rhq-agent-env.sh", "1", false, true, null, true);
         uploadForm.setCustomTooltipMessage(MSG.view_remoteAgentInstall_promptRhqAgentEnv());
-        uploadForm.setWidth100();
+        uploadForm.setAutoWidth();
+        uploadForm.setPadding(5);
+        uploadForm.setIsGroup(true);
+        uploadForm.setGroupTitle("rhq-agent-env.sh");
         uploadForm.addFormHandler(new DynamicFormHandler() {
             @Override
             public void onSubmitComplete(DynamicFormSubmitCompleteEvent event) {
@@ -542,7 +552,7 @@ public boolean execute() {
 
     private void reallyInstallAgent() {
         disableButtons(true);
-        agentStatusText.setValue("Installing, this may take a few minutes...");
+        agentStatusText.setValue(MSG.view_remoteAgentInstall_installingPleaseWait());
         SC.ask(MSG.view_remoteAgentInstall_overwriteAgentTitle(), MSG.view_remoteAgentInstall_overwriteAgentQuestion(),
             new BooleanCallback() {
                 @Override

modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/admin/topology/AgentTableView.java

@@ -193,8 +193,8 @@ private void showRemoteAgentInstallView(AgentInstall ai) {
                             RemoteAgentInstallView remoteAgentView = new RemoteAgentInstallView(ai, Type.START);
                             PopupWindow window = new PopupWindow(remoteAgentView);
                             window.setTitle(MSG.view_adminTopology_agent_start());
-                            window.setHeight(300);
-                            window.setWidth(800);
+                            window.setHeight(350);
+                            window.setWidth(850);
                             window.show();
                             refreshTableInfo();
                         }
@@ -234,8 +234,8 @@ private void showRemoteAgentInstallView(AgentInstall ai) {
                             RemoteAgentInstallView remoteAgentView = new RemoteAgentInstallView(ai, Type.STOP);
                             PopupWindow window = new PopupWindow(remoteAgentView);
                             window.setTitle(MSG.view_adminTopology_agent_stop());
-                            window.setHeight(300);
-                            window.setWidth(800);
+                            window.setHeight(350);
+                            window.setWidth(850);
                             window.show();
                             refreshTableInfo();
                         }
@@ -289,8 +289,8 @@ public void onSuccess(AgentInstall result) {
 
                                             final PopupWindow window = new PopupWindow(remoteAgentView);
                                             window.setTitle(MSG.view_adminTopology_agent_uninstall());
-                                            window.setHeight(300);
-                                            window.setWidth(800);
+                                            window.setHeight(350);
+                                            window.setWidth(850);
                                             window.show();
 
                                             remoteAgentView

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages.properties

@@ -2129,6 +2129,7 @@ view_remoteAgentInstall_error_needAbsPath = You must provide an absolute path (i
 view_remoteAgentInstall_installAgent = Install Agent
 view_remoteAgentInstall_installInfo = Agent Installation Information
 view_remoteAgentInstall_installPath = Agent Install Path
+view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = Owner

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_cs.properties

@@ -2153,6 +2153,7 @@ view_remoteAgentInstall_error_6 = Nepodařilo se zastavit agenta
 view_remoteAgentInstall_installAgent = Instalovat agenta
 view_remoteAgentInstall_installInfo = Informace o instalaci agenta
 view_remoteAgentInstall_installPath = Instalační cesta k agentovi
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = Vlastník

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_de.properties

@@ -2591,6 +2591,7 @@ view_remoteAgentInstall_error_6 = Konnte den Agent nicht stoppen
 view_remoteAgentInstall_installAgent = Agent installieren
 view_remoteAgentInstall_installInfo = Informationen zur Agent-Installation
 view_remoteAgentInstall_installPath = Pfad der Agent-Installation
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = Eigentümer

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_ja.properties

@@ -2182,6 +2182,7 @@ view_remoteAgentInstall_error_6 = エージェントの停止に失敗しまし
 ##view_remoteAgentInstall_error_needAbsPath = You must provide an absolute path (i.e. a path starting with "/") when performing this operation.
 view_remoteAgentInstall_installAgent = エージェントのインストール
 view_remoteAgentInstall_installPath = エージェントのインストールパス
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 ##view_remoteAgentInstall_promptAgentConfigXml = A custom agent configuration file that you want the new agent to use. This is optional. If you do not provide a file, the agent will simply use its defaults.

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_ko.properties

@@ -1839,6 +1839,7 @@ view_remoteAgentInstall_error_6 = 에이전트 중지에 실패했습니다
 view_remoteAgentInstall_installAgent = 에이전트 설치
 view_remoteAgentInstall_installInfo = 에이전트 설치 정보
 view_remoteAgentInstall_installPath = 에이전트 설치 경로
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = 소유자

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_pt.properties

@@ -2227,6 +2227,7 @@ view_remoteAgentInstall_error_6 = Falha ao parar o agente
 view_remoteAgentInstall_installAgent = Instalar Agente
 view_remoteAgentInstall_installInfo = Informa\u00E7\u00E3o sobre a instala\u00E7\u00E3o do Agente
 view_remoteAgentInstall_installPath = Caminho de Instala\u00E7\u00E3o do Agente
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = Propriet\u00E1rio

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_ru.properties

@@ -3014,6 +3014,7 @@ view_group_detail_implicitAvail = Group availability for all members (includes r
 ##view_remoteAgentInstall_error_cannotPingAgent = Agent was installed on host [{0}] but it failed to be pinged on port [{1}] . Please make sure it has been fully configured and ensure there is no firewall blocking traffic to its endpoint.
 ##view_remoteAgentInstall_error_needAbsPath = You must provide an absolute path (i.e. a path starting with "/") when performing this operation.
 ##view_remoteAgentInstall_installAgent = Install Agent
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 ##view_remoteAgentInstall_promptAgentConfigXml = A custom agent configuration file that you want the new agent to use. This is optional. If you do not provide a file, the agent will simply use its defaults.

modules/enterprise/gui/coregui/src/main/resources/org/rhq/coregui/client/Messages_zh.properties

@@ -2120,6 +2120,7 @@ view_remoteAgentInstall_error_6 = \u505c\u6b62\u4ee3\u7406\u5931\u8d25
 view_remoteAgentInstall_installAgent = \u5b89\u88c5\u4ee3\u7406
 view_remoteAgentInstall_installInfo = \u4ee3\u7406\u5b89\u88c5\u4fe1\u606f
 view_remoteAgentInstall_installPath = \u4ee3\u7406\u5b89\u88c5\u8def\u5f84
+##view_remoteAgentInstall_installingPleaseWait = Installing, this may take a few minutes...
 ##view_remoteAgentInstall_overwriteAgentQuestion = If there is already an agent installed, do you want to overwrite it?
 ##view_remoteAgentInstall_overwriteAgentTitle = Overwrite Existing Agent?
 view_remoteAgentInstall_owner = \u6240\u6709\u8005