[BZ 1155822] Validate that pid is a numeric value

rhq-project · Nov 27, 2014 · 58cdc87 · 58cdc87
1 parent 1c067b9
commit 58cdc87
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/...enterprise/server/server-control/src/main/java/org/rhq/server/control/ControlCommand.java b/...enterprise/server/server-control/src/main/java/org/rhq/server/control/ControlCommand.java
@@ -492,6 +492,12 @@ protected void killPid(String pid) throws IOException {
     }
 
     protected boolean isUnixPidRunning(String pid) {
+        try {
+            Integer numericPid = Integer.valueOf(pid);
+        } catch(NumberFormatException e) {
+            // PID wasn't numeric, it can't be correct
+            return false;
+        }
 
         Executor executor = new DefaultExecutor();
         executor.setWorkingDirectory(getBinDir());