Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Commit

Permalink
[BZ 1078546] Relax remote client version check so that patched but n…
Browse files Browse the repository at this point in the history
…on-breaking api changes accepted.
  • Loading branch information
spinder committed Oct 3, 2014
1 parent 47ae8ff commit d95dea1
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import org.jboss.remoting.transport.http.ssl.HTTPSClientInvoker;

import org.rhq.bindings.client.AbstractRhqFacade;
import org.rhq.bindings.client.RhqFacade;
import org.rhq.bindings.client.RhqManager;
import org.rhq.bindings.util.InterfaceSimplifier;
import org.rhq.core.domain.auth.Subject;
Expand Down Expand Up @@ -513,7 +512,12 @@ private void checkServerSupported(ProductInfo serverVersionInfo) throws IllegalS
serverVersionString = this.serverInfo.getVersion();
ComparableVersion clientVersion = new ComparableVersion(clientVersionString);
ComparableVersion serverVersion = new ComparableVersion(serverVersionString);
supported = clientVersion.equals(serverVersion);
int laterVersionCheck = clientVersion.compareTo(serverVersion);
if (laterVersionCheck >= 0) {
supported = true; //Ex. 3.2.0.GA-redhat-N represent supported non-breaking api patches/changes.
} else {
supported = false;
}
} catch (Exception e) {
throw new IllegalStateException("Cannot determine if server version is supported.", e); // assume we can't talk to it
}
Expand Down

0 comments on commit d95dea1

Please sign in to comment.