Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "trash_srl" attribute to the $obj when invoking the "document.moveDocumentToTrash" (after) trigger. #2141

Closed
wants to merge 1 commit into from

Conversation

Eundong
Copy link
Contributor

@Eundong Eundong commented Jul 4, 2023

"document.moveDocumentToTrash" (after) 트리거에서 새롭게 휴지통에 삽입된 녀석의 trash_srl 을 가져올수 없어서 $obj->trash_srl 에 포함되도록 수정했습니다.

….moveDocumentToTrash" (after) trigger.

"document.moveDocumentToTrash" (after) 트리거에서 새롭게 휴지통에 삽입된 녀석의 trash_srl 을 가져올수 없어서 $obj->trash_srl 에 포함되도록 수정했습니다.
@Eundong Eundong changed the base branch from master to develop July 4, 2023 22:13
@kijin
Copy link
Member

kijin commented Jul 5, 2023

문법 오류가 있습니다. 다시 확인 부탁드립니다.

$oTrashVO를 조작하는 도중에 트리거 오브젝트에 값을 넣는 코드를 끼워넣기보다는,
트리거 호출 직전에 $obj->trash_srl = $oTrashVO->getTrashSrl();과 같이
입력 완료된 정보를 받아오는 것이 좀더 깔끔할 것 같습니다.

kijin added a commit that referenced this pull request Jul 5, 2023
@kijin kijin closed this Jul 5, 2023
@Eundong
Copy link
Contributor Author

Eundong commented Jul 5, 2023

앗 제가 제대로 체크 못하고 PR을 드렸네요. 더 깔끔한 방식으로 수정해주셔서 감사합니다.

@Eundong Eundong deleted the patch-1 branch July 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants