[rust] Make Debug implementation for Uri use percent encoding #3

not-my-profile · 2021-11-10T09:08:32Z

Currently the Uri struct is defined as follows:

#[derive(Clone, Debug, Default, PartialEq)]
pub struct Uri {
    scheme: Option<String>,
    authority: Option<Authority>,
    path: Vec<Vec<u8>>,
    query: Option<Vec<u8>>,
    fragment: Option<Vec<u8>>,
}

Which results in path, query and fragment being printed as number arrays in debug mode e.g. println!("{:?}", Uri::parse("test")); results in:

Ok(Uri { scheme: None, authority: None, path: [[116, 101, 115, 116]], query: None, fragment: None })

I would find the debug output more readable if path, query and fragment were printed in percent-encoding.

If you think this is a good idea, I'm happy to send a pull request.

The text was updated successfully, but these errors were encountered:

Previously an assertion like: assert_eq!(Uri::parse("some/path"), Uri::parse("other/path")); resulted in a panic like: thread 'uri::tests::example' panicked at 'assertion failed: `(left == right)` left: `Ok(Uri { scheme: None, authority: None, path: [[115, 111, 109, 101], [112, 97, 116, 104]], query: None, fragment: None })`, right: `Ok(Uri { scheme: None, authority: None, path: [[111, 116, 104, 101, 114], [112, 97, 116, 104]], query: None, fragment: None })`' This commit changes the Debug impl to be more developer friendly: thread 'uri::tests::foobar' panicked at 'assertion failed: `(left == right)` left: `Ok(Uri("some/path"))`, right: `Ok(Uri("other/path"))`' Fixes rhymu8354#3.

Previously an assertion like: assert_eq!(Uri::parse("some/path"), Uri::parse("other/path")); resulted in a panic like: thread 'uri::tests::example' panicked at 'assertion failed: `(left == right)` left: `Ok(Uri { scheme: None, authority: None, path: [[115, 111, 109, 101], [112, 97, 116, 104]], query: None, fragment: None })`, right: `Ok(Uri { scheme: None, authority: None, path: [[111, 116, 104, 101, 114], [112, 97, 116, 104]], query: None, fragment: None })`' This commit changes the Debug impl to be more developer friendly: thread 'uri::tests::example' panicked at 'assertion failed: `(left == right)` left: `Ok(Uri("some/path"))`, right: `Ok(Uri("other/path"))`' Fixes rhymu8354#3.

not-my-profile mentioned this issue Dec 5, 2021

[rust] Resolving "bar" relative to base "foo" results in "foo/bar" #4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rust] Make Debug implementation for Uri use percent encoding #3

[rust] Make Debug implementation for Uri use percent encoding #3

not-my-profile commented Nov 10, 2021 •

edited

[rust] Make Debug implementation for Uri use percent encoding #3

[rust] Make Debug implementation for Uri use percent encoding #3

Comments

not-my-profile commented Nov 10, 2021 • edited

not-my-profile commented Nov 10, 2021 •

edited