Skip to content

Commit

Permalink
now workflow call is available in matrix (fix #197)
Browse files Browse the repository at this point in the history
  • Loading branch information
rhysd committed Aug 24, 2022
1 parent ff1e959 commit 4da232c
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
1 change: 0 additions & 1 deletion parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,6 @@ func (p *parser) parseJob(id *String, n *yaml.Node) *Job {
stepsOnlyKey = k
case "strategy":
ret.Strategy = p.parseStrategy(k.Pos, v)
stepsOnlyKey = k
case "continue-on-error":
ret.ContinueOnError = p.parseBool(v)
stepsOnlyKey = k
Expand Down
17 changes: 17 additions & 0 deletions testdata/ok/workflow_call_with_strategy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Reusable workflow with matrix strategy

# This was enabled by https://github.blog/changelog/2022-08-22-github-actions-improvements-to-reusable-workflows-2/
#
# Doc: https://docs.github.com/en/actions/using-workflows/reusing-workflows#example-matrix-strategy-with-a-reusable-workflow

on:
push:

jobs:
ReuseableMatrixJobForDeployment:
strategy:
matrix:
target: [dev, stage, prod]
uses: octocat/octo-repo/.github/workflows/deployment.yml@main
with:
target: ${{ matrix.target }}

0 comments on commit 4da232c

Please sign in to comment.