Download script downloads previous version

[SnowCait]

I try to download v1.6.17 because actionlint was broken by #216 but v1.6.17 download script downloads v1.6.16.
(Go is not installed in my self-hosted runner, therefore I use download script.)

bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/v1.6.17/scripts/download-actionlint.bash)

v1.6.17 is c9980ce.

actionlint/scripts/download-actionlint.bash

Line 46 in c9980ce

version="1.6.16"

This is caused by release workflow that rewrites download script version after tagged.
Download script version should be rewrited before tagged.

actionlint/.github/workflows/release.yaml

Lines 1 to 5 in 0ea32b7

	name: Release
	on:
	push:
	tags:
	- "v*.*.*"

actionlint/.github/workflows/release.yaml

Lines 34 to 44 in 0ea32b7

	- name: Update version in download script
	run: |
	set -x
	ver="${GITHUB_REF#refs/tags/v}"
	cd ./tmp-actionlint-for-update-ver
	sed -i -E "s/version=\"[0-9]+\\.[0-9]+\\.[0-9]+\"/version=\"${ver}\"/" ./scripts/download-actionlint.bash
	git diff
	git add ./scripts/download-actionlint.bash
	git -c user.email='41898282+github-actions[bot]@users.noreply.github.com' -c user.name='github-actions[bot]' commit -m "update version to $ver in download-actionlint.bash"
	git log -n 1
	git push

[SnowCait]

It seems to be specifiable with arg but it's not documented and hard to understand because it shows both main and v1.6.17 versions.

actionlint/scripts/download-actionlint.bash

Lines 47 to 58 in 0ea32b7

	if [ -n "$1" ]; then
	if [[ "$1" != 'latest' && "$1" != 'LATEST' ]]; then
	if [[ "$1" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
	version="$1"
	else
	echo "Given version '$1' does not match to regex '^[0-9]+\.[0-9]+\.[0-9]+$' nor equal to 'latest'" >&2
	echo >&2
	usage
	exit 1
	fi
	fi
	fi

[rhysd]

You're misundesrstanding usage of the script. Give the version as command line option.

https://github.com/rhysd/actionlint/blob/main/scripts/download-actionlint.bash#L33

[rhysd]

bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) 1.6.17

is correct.

[SnowCait]

@rhysd

hard to understand because it shows both main and v1.6.17 versions.

My argument is this.
The current usage that fixes script version to main is not so good for me.

If you don't want to change usage, would you please document that in install.md?
It is difficult to find usage that is written in script.

[rhysd]

OK, I got your point. I can't change the script interface because it means a breaking change. I'll check document and update it as needed.