Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-output is deprecated #234

Closed
larrys opened this issue Oct 12, 2022 · 6 comments
Closed

set-output is deprecated #234

larrys opened this issue Oct 12, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@larrys
Copy link

larrys commented Oct 12, 2022

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I am getting the following warning when running actionlint

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@rhysd rhysd added the enhancement New feature or request label Oct 13, 2022
@rhysd
Copy link
Owner

rhysd commented Oct 13, 2022

It would be great if we can catch this. However, how can we check it statically? The deprecated command is run by outputting a command to stdout dynamically.

@wtfiscrq
Copy link

@rhysd you mean statically check if a command is deprecated?

@Gudahtt
Copy link

Gudahtt commented Oct 25, 2022

actionlint itself is using the deprecated command. e.g. https://github.com/rhysd/actionlint/blob/main/scripts/download-actionlint.bash#L135

Catching usage of this deprecated command would be useful, but I don't think that's what this issue was requesting.

@rhysd
Copy link
Owner

rhysd commented Oct 26, 2022

you mean statically check if a command is deprecated?

No. I meant statically detecting the command is used.

actionlint itself is using the deprecated command.

Yes. I said this idea would be great if it can be realized without false positive in #234 (comment).

@rhysd
Copy link
Owner

rhysd commented Oct 26, 2022

Today I have some time to implement this with simple pattern matching. I will try it and look if it causes some false positives or not.

@rhysd rhysd closed this as completed in 43f6ff2 Oct 26, 2022
@rhysd
Copy link
Owner

rhysd commented Nov 1, 2022

v1.6.22 included this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants