Skip to content

Commit

Permalink
remove win_title option from README and type definition, which actual…
Browse files Browse the repository at this point in the history
…ly does not exist

related: #43
  • Loading branch information
rhysd committed Sep 4, 2019
1 parent 8ce5e3c commit 3655b45
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ export default function openAboutWindow(info: {
win_options?: BrowserWindowOptions;
use_version_info?: boolean;
show_close_button?: string;
win_title?: string;
}): BrowserWindow
```

Expand Down Expand Up @@ -94,7 +93,6 @@ $ npm run debug
| `use_version_info` | If `false`, the versions of electron, chrome, node, and v8 will not be displayed. Default is `true`. **Optional** | boolean |
| `show_close_button` | If this is a valid string, a close button with this string be displayed. **Optional** | string |
| `about_page_dir` | Directory path which contains `about.html` which is rendered in 'About this app' window. **Optional** | string |
| `win_title` | Title string of the window. Default title is `About {app name}`. **Optional** | string |

**Note:** If you set `use_inner_html` to `true`, please ensure that contents don't contain any untrusted external input
in order to avoid XSS. Be careful.
Expand Down
1 change: 0 additions & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export interface AboutWindowInfo {
use_inner_html?: boolean;
use_version_info?: boolean;
show_close_button?: string;
win_title?: string;
}

export default function openAboutWindow(into: AboutWindowInfo | string): Electron.BrowserWindow;

0 comments on commit 3655b45

Please sign in to comment.