Allow option for hiding version information #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexanderturinske
commented
May 31, 2018
•
alexanderturinske
commented
- Fixes Question: is it possible to not show electron/chrome/node/v8 info #24
|
I'm sorry that I failed to catch this PR. Let me review. |
rhysd
requested changes
Jun 12, 2018
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "about-window", | |||
| "version": "1.11.0", | |||
| "version": "1.12.0", | |||
There was a problem hiding this comment.
Could you revert this change? Let me create another commit to bump version to create a tag commit after merging this PR.
|
@alexanderturinske Could you show me the screenshot how it looks like when setting |
- add new option to README - revert version change
|
rhysd
approved these changes
Jun 27, 2018
|
I will publish new version after merging #26 |
|
@rhysd I think that this PR did not make it to the latest release 🤔 It seems that the |
|
@bampakoa Thank you for reporting that. I released 1.12.1. Could you try it? |
|
@rhysd it works fine in 1.12.1 Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.