Make the package Electron 5 compatible #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required setting nodeIntegrations option for window to true (on by default in earlier versions). NodeIntegrations _can_ be a security risk if there is a way to load remote content through the window, but I could not find any way.
|
Thanks! Who can review and merge this pull request? |
|
For those who are waiting for this to be merged, I have posted a temporary solution: #37 (comment) |
|
I'm sorry for the delay. Thank you for the patch. |
rhysd
approved these changes
May 16, 2019
|
This patch is included in v1.13.0. https://github.com/rhysd/electron-about-window/releases/tag/v1.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required setting
nodeIntegrationsoption for window to true (on by default in earlier versions).nodeIntegrationscan be a security risk if there is a way to load remote content through the window, but I could not find any way.Solves #37