Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty branch name navigates to 404 error page #26

Closed
rhysd opened this issue Aug 31, 2020 · 0 comments
Closed

Empty branch name navigates to 404 error page #26

rhysd opened this issue Aug 31, 2020 · 0 comments
Labels
bug
Projects
git-brws

Comments

@rhysd
Copy link
Owner

rhysd commented Aug 31, 2020

Repro

git brws -b ''

Expected results

Error because branch name cannot be empty

Actual results

Opens https://github.com/{owner}/tree/ and it causes 404 error in browser.
@rhysd rhysd added the bug label Aug 31, 2020
@rhysd rhysd closed this as completed in 991ee21 Aug 31, 2020
rhysd added a commit that referenced this issue Aug 31, 2020
@rhysd
check branch name is not empty (fix #26)
735c986
@rhysd rhysd added this to Inbox in git-brws Aug 31, 2020
@rhysd rhysd moved this from Inbox to Done in git-brws Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
git-brws
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhysd