Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when quitting the check window with #53

Closed
languitar opened this issue Dec 20, 2017 · 12 comments
Closed

Error message when quitting the check window with #53

languitar opened this issue Dec 20, 2017 · 12 comments

Comments

@languitar
Copy link

When I close the checking window with q, I always see the following error message:

Error detected while processing function grammarous#info_win#action_quit:
line    3:
E108: No such variable: "b:grammarous_preview_bufnr"
@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

Could you provide more information about your environment to reproduce problem? At least it does not reproduce in my local.

  • Vim version (i.e. 7.4.x or 8.0.x or Neovim 2.x or ...)
  • Your OS

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

I improved to close preview window. Could you try out the latest?

@languitar
Copy link
Author

languitar commented Dec 21, 2017

This is gone with the update. :) I am running neovim 0.2.2 on Linux. But from the commit I see why this happens. After closing the check window, the cursor jumps to a different buffer.

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

Yes. Thank you for confirming. I’m closing this.

@rhysd rhysd closed this as completed Dec 21, 2017
@languitar
Copy link
Author

Is there any way to actually return to the correct buffer afterwards?

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

Currently there is no way to do that. 'quit' action only :quit the window with cleanup.

@languitar
Copy link
Author

I think I once had a discussion on how to achieve this reliably in vimtex in this issue: lervag/vimtex#637 Maybe you could adapt the solution there?

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

Actually I can implement it easily. Not understanding it's practically useful or not (because I'm satisfied with current behavior).

@languitar
Copy link
Author

For my workflow I always have several windows open and of the cursor jumps back to a different one after closing the checking window, I actually have to do something to get it back to the window I was actually working in. So I'd appreciate a solution for that ;-)

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

ok, I'll change the behavior of quit action.

@rhysd
Copy link
Owner

rhysd commented Dec 21, 2017

Please update to the latest and try out.

@languitar
Copy link
Author

Seems to work well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants