Refactor for multiple dbs, firewall, vnet rules #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make resource group creation optional
sblack4
approved these changes
Feb 5, 2020
| output "database_name" { | ||
| description = "The database name of MySQL Server." | ||
| value = azurerm_mysql_database.mysql.name | ||
| } |
There was a problem hiding this comment.
Because I'm using a map now to create multiple databases, thus the dbs var.
There was a problem hiding this comment.
ohh yeah that'll mess up the output that I don't know if we need. I think that makes this a major release?
There was a problem hiding this comment.
Yeah, I was tagging this 3.0.0
sblack4
reviewed
Feb 5, 2020
| @@ -1,13 +1,18 @@ | |||
| provider "azurerm" { | |||
| version = ">=1.40.0" | |||
There was a problem hiding this comment.
This will cause problems if we're using a different provider version
There was a problem hiding this comment.
I can knock it down to a lesser version, but I haven't tested it on those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make resource group creation optional
This breaks heavily anyone using v2. Didn't update tests or documentation; will do that in a later revision.