Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps, lint): add lint with husky and lint-staged #18

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

r17x
Copy link
Collaborator

@r17x r17x commented Sep 29, 2021

No description provided.

@vercel
Copy link

vercel bot commented Sep 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ri7nz/rescript-chakra/J6CrnzKg8fGiULtmassrQwy5qbth
✅ Preview: Failed

@r17x r17x merged commit 987d76a into next Sep 29, 2021
@tjbo
Copy link
Contributor

tjbo commented Sep 29, 2021

I was trying to make a fix today for select menu, but couldn't commit.

✔ Preparing...
⚠ Running tasks...
  ↓ No staged files match *.{md,json,js} [SKIPPED]
  ❯ Running tasks for *.{res,resi}
    ✖ bsrefmt [FAILED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up...

✖ bsrefmt:
refmt: Cannot determine default implementation parser for filename
       '/Users/tjbo/Projects/rescript-chakra/src/Components/Chakra__Select.res'.
Usage: refmt [OPTION]... [FILENAMES]...
Try `refmt --help' for more information.
Error happened when running command /Users/tjbo/Projects/rescript-chakra/node_modules/rescript/darwin/refmt.exe with args [
  '/Users/tjbo/Projects/rescript-chakra/src/Components/Chakra__Select.res'
]
husky - pre-commit hook exited with code 1 (error)

https://share.getcloudapp.com/nOuvjgBo

Maybe refmt, needs another setting or option?

@tjbo
Copy link
Contributor

tjbo commented Sep 29, 2021

This fixed it for me... but it seems a lil hacky.

https://forum.rescript-lang.org/t/reformat-rescript-in-place/207/11

@tjbo
Copy link
Contributor

tjbo commented Sep 29, 2021

I don't know if you've tested it but according to the repo, maybe you haven't, so it should be easy for you to reproduce on your machine.

1 - Change a .res file
2 - Try to make a commit

I think it should fail for you too, but not positive, maybe it's working for you.

@tjbo
Copy link
Contributor

tjbo commented Sep 29, 2021

-format

I think adding this flag to the package.json also fixes it.

@r17x
Copy link
Collaborator Author

r17x commented Sep 30, 2021

@tjbo thanks, I missing commit rescript format for bsfmt.

Here's for PRs

#20

in your forked repository, you can make it up to date with rebase from this repository (as upstream) .

github-actions bot pushed a commit that referenced this pull request Oct 3, 2021
# [1.2.0-next.8](v1.2.0-next.7...v1.2.0-next.8) (2021-10-03)

### Bug Fixes

* **Select:** fix custom colors ([#22](#22)) ([8d9182e](8d9182e))

### Chores

* fix lint-staged for res or resi ([#20](#20)) ([6054fc9](6054fc9))
* **deps, lint:** add lint with husky and lint-staged ([#18](#18)) ([987d76a](987d76a))

### Documentation

* **Website:** add docs website ([#19](#19)) ([1e27b6b](1e27b6b))
@r17x
Copy link
Collaborator Author

r17x commented Oct 3, 2021

🎉 This PR is included in version 1.2.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@r17x r17x added the released label Oct 3, 2021
@r17x r17x deleted the chore/husky branch October 3, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants