Feat: Improve Version 0.8.0 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for multi-services example;
…erProvider to always sample the trace;
Feat: Implement `WithPublicEndpoint` & `WithPublicEndpointFn` Options
riandyrn
requested review from
ilhamsyahids,
mustafasegf and
ProtozoaJr
as code owners
ProtozoaJr
previously approved these changes
Apr 28, 2024
There was a problem hiding this comment.
LGTM! Thank you for this PR, so that in version 0.8.0 we will have the PublicEndpoint feature like in otelmux. Then, the problem of the Jaeger exporter module being deprecated has been resolved by using the otlptrace exporter. Last but not least, thank you for reminding me through this request to change the go version in compatibility-test
ProtozoaJr
reviewed
Apr 28, 2024
There was a problem hiding this comment.
If @ilhamsyahids review has been resolved, then we can merge this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary:
0.49.0since it is the version that uses otel1.24.0internally, check here for details.multi-servicesexample & useotlptraceexporter instead.WithPublicEndpoint&WithPublicEndpointFnoptions in Feat: ImplementWithPublicEndpoint&WithPublicEndpointFnOptions #43.compatibility-test.ymlto1.19,1.20, &1.21.