-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve Version 0.8.0 #42
Conversation
… for multi-services example;
…erProvider to always sample the trace;
Feat: Implement `WithPublicEndpoint` & `WithPublicEndpointFn` Options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for this PR, so that in version 0.8.0 we will have the PublicEndpoint
feature like in otelmux. Then, the problem of the Jaeger exporter module being deprecated has been resolved by using the otlptrace exporter
. Last but not least, thank you for reminding me through this request to change the go version in compatibility-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @ilhamsyahids review has been resolved, then we can merge this PR
Changes Summary:
0.49.0
since it is the version that uses otel1.24.0
internally, check here for details.multi-services
example & useotlptrace
exporter instead.WithPublicEndpoint
&WithPublicEndpointFn
options in Feat: ImplementWithPublicEndpoint
&WithPublicEndpointFn
Options #43.compatibility-test.yml
to1.19
,1.20
, &1.21
.