Ignore timezone if two periods are compared for equality #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the case where exception dates are ignored due to different time zone than the recurring event.
rbuehlma
force-pushed
the
caldatetime_equals
branch
from
c2b6779
to
c17f0be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the case where exception dates are ignored due to different time zone than the recurring event.
This PR is a follow up to #307.
On IDateTime there were cases where it was required to honour the timezone in equals.
Therefore, this PR changes the Equals on "Period" which also solves the issue. Are there also cases where the Timezone for a Period is relevant in case of comparing them? I currently cant think of one and therefore think this could be a nice fix for my issue.
What is your opinion on that?
If its ok, I will also update the v2-version and do the package updates.