This repository has been archived by the owner on Nov 21, 2020. It is now read-only.
Bugfix for Issue 14 - Unknown resolution #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ower res if individual chapters not available at max resolution.
|
thank you very much @jonathanoster for looking into it 👍 , i'll go through the changes and make some refinements if needed, and will soon merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Going to preface the message with a note that I'm not an engineer and this would be the first time ever using git so I'm not 100% certain I got it all right. If I did the steps correctly I should have committed a bugfix to a new branch that resolved the bug reported as Issue 14 for udemy-dl. The problem I (and likely other users) were running into was that there were select chapters for a given lesson that were not available in the same resolution as the rest of the course.
I resolved this by changing the if(!url) check into a while loop failing back to progressively lower resolutions until a valid url was found. This allowed the majority of the course to be downloaded in my preferred resolution and each individual course unavailable in that resolution to continue through at the next available.
The resolution printed to the console during download still appears to be displayed as my max preference instead of what is used for that individual download, but I was unable to see where to make that edit.
-Jonathan