Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dota 2 Web API] bug report for Dota2Heroes,match_seq_num #19

Closed
John-Chan opened this issue Nov 3, 2017 · 0 comments
Closed

[Dota 2 Web API] bug report for Dota2Heroes,match_seq_num #19

John-Chan opened this issue Nov 3, 2017 · 0 comments
Assignees
Milestone

Comments

@John-Chan
Copy link
Contributor

AGQL version

0.1.5

bugs

1. pojo object Dota2Heroes should have a filed for localized_name .

The original response(from https://api.steampowered.com/IEconDOTA2_570/GetHeroes/v1?language=en&itemizedonly=false&key=) :

{
"result": {
	"heroes": [
		{
		"name": "npc_dota_hero_antimage",
		"id": 1,
		"localized_name": "Anti-Mage"
		},
		{
		"name": "npc_dota_hero_axe",
		"id": 2,
		"localized_name": "Axe"
		}
		...
		]
	}
}

Maybe the class Dota2Heroes should rename to Dota2Hero

2. match_seq_num is not int32

For example,check the original response(from https://api.steampowered.com/IDOTA2Match_570/GetMatchHistory/v1?account_id=125038361&key=) :

{
"result": {
	"status": 1,
	"num_results": 100,
	"total_results": 199,
	"results_remaining": 99,
	"matches": [
		{
		"match_id": 3530014921,
		"match_seq_num": 3071690874,
		"start_time": 1509289271,
		"lobby_type": 0,
		"radiant_team_id": 0,
		"dire_team_id": 0,
		"players": [ ... ]
		},
		...
		]
	}

}

Maybe it a unsigned int32 or int64 type on server side, as a java client we should use long to avoid data losss .

related pojo object:Dota2MatchDetails,Dota2MatchHistory,Dota2MatchHistoryInfo

@John-Chan John-Chan mentioned this issue Nov 3, 2017
@ribasco ribasco self-assigned this Nov 14, 2017
@ribasco ribasco added this to the RELEASE-0.2.0 milestone Nov 14, 2017
ribasco added a commit that referenced this issue May 4, 2022
Signed-off-by: Rafael Luis Ibasco <ribasco@gmail.com>

Fixes #19: Rename Dota2Heroes to Dota2Hero

Signed-off-by: Rafael Luis Ibasco <ribasco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants