We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.5
Dota2Heroes
localized_name
The original response(from https://api.steampowered.com/IEconDOTA2_570/GetHeroes/v1?language=en&itemizedonly=false&key=) :
https://api.steampowered.com/IEconDOTA2_570/GetHeroes/v1?language=en&itemizedonly=false&key=
{ "result": { "heroes": [ { "name": "npc_dota_hero_antimage", "id": 1, "localized_name": "Anti-Mage" }, { "name": "npc_dota_hero_axe", "id": 2, "localized_name": "Axe" } ... ] } }
Maybe the class Dota2Heroes should rename to Dota2Hero
Dota2Hero
match_seq_num
For example,check the original response(from https://api.steampowered.com/IDOTA2Match_570/GetMatchHistory/v1?account_id=125038361&key=) :
https://api.steampowered.com/IDOTA2Match_570/GetMatchHistory/v1?account_id=125038361&key=
{ "result": { "status": 1, "num_results": 100, "total_results": 199, "results_remaining": 99, "matches": [ { "match_id": 3530014921, "match_seq_num": 3071690874, "start_time": 1509289271, "lobby_type": 0, "radiant_team_id": 0, "dire_team_id": 0, "players": [ ... ] }, ... ] } }
Maybe it a unsigned int32 or int64 type on server side, as a java client we should use long to avoid data losss .
unsigned int32
int64
long
related pojo object:Dota2MatchDetails,Dota2MatchHistory,Dota2MatchHistoryInfo
Dota2MatchDetails
Dota2MatchHistory
Dota2MatchHistoryInfo
The text was updated successfully, but these errors were encountered:
Reverted changes. Moved for the next major release (Issue #19)
1a865b9
Fix data type mismatch for pojos (Issue #19)
44561e3
Fixes #19, #20, #21
b612971
Signed-off-by: Rafael Luis Ibasco <ribasco@gmail.com> Fixes #19: Rename Dota2Heroes to Dota2Hero Signed-off-by: Rafael Luis Ibasco <ribasco@gmail.com>
ribasco
No branches or pull requests
AGQL version
0.1.5
bugs
1. pojo object
Dota2Heroes
should have a filed forlocalized_name
.The original response(from
https://api.steampowered.com/IEconDOTA2_570/GetHeroes/v1?language=en&itemizedonly=false&key=
) :2.
match_seq_num
is not int32For example,check the original response(from
https://api.steampowered.com/IDOTA2Match_570/GetMatchHistory/v1?account_id=125038361&key=
) :Maybe it a
unsigned int32
orint64
type on server side, as a java client we should uselong
to avoid data losss .related pojo object:
Dota2MatchDetails
,Dota2MatchHistory
,Dota2MatchHistoryInfo
The text was updated successfully, but these errors were encountered: