Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved unknown download error if a podcast episode added to download list has gone from the feed #236

Closed
ribbons opened this issue Nov 27, 2019 · 0 comments
Closed

Resolved unknown download error if a podcast episode added to download list has gone from the feed #236

ribbons opened this issue Nov 27, 2019 · 0 comments
Assignees
@ribbons
Labels
bug Something isn't working fixed
Milestone
0.34

Comments

@ribbons
Copy link
Owner

ribbons commented Nov 27, 2019

If a podcast episode has been added to the download list but the download isn't attempted until later when it has gone from the podcast feed, the following exception will occur in the Podcast provider:

System.NullReferenceException
   at PodcastProvider.PodcastProvider.DownloadProgramme(String progExtId, String episodeExtId, ProgrammeInfo progInfo, EpisodeInfo epInfo, String finalName) in E:\Development\Radio Downloader\Providers\PodcastProvider\Classes\PodcastProvider.cs:line 394
   at RadioDld.DownloadHandler.DownloadProgThread() in E:\Development\Radio Downloader\Classes\DownloadHandler.cs:line 224
@ribbons ribbons added the bug Something isn't working label Nov 27, 2019
@ribbons ribbons added this to the 0.34 milestone Nov 27, 2019
@ribbons ribbons self-assigned this Nov 27, 2019
ribbons added a commit that referenced this issue Nov 27, 2019
@ribbons
Correctly handle podcast episodes no-longer in xml
7a280a6 
Prevent a NullReferenceException from occuring in the Podcast provider
if a podcast episode has disappeared from the feed since it was added to
the download list.  Instead, return a DownloadException with an
ErrorType of RemoveFromList so that it gets cleaned up from the list.

Resolves #236
@ribbons ribbons added the fixed label Nov 28, 2019
@ribbons ribbons changed the title Unknown download error if a podcast episode added to download list has gone from the feed Resolved unknown download error if a podcast episode added to download list has gone from the feed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ribbons ribbons

Labels
bug Something isn't working fixed
Projects
None yet
Milestone
0.34
Development

No branches or pull requests
1 participant
@ribbons