Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tcp starttls test for smtp #167

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Conversation

dragoangel
Copy link
Contributor

When SMTP capability listed as last option it described by " " (space), in nginx smtp proxy with starttls offloading it's common that starttls placed in last sequence, resulting in faled tests from ssl_exporter aka:

220 my-smtp-server ESMTP ready
EHLO prober
250-my-smtp-server
250-SIZE 55000000
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-SMTPUTF8
250-CHUNKING
250-AUTH PLAIN LOGIN
250 STARTTLS

This PR should fix such cases

@dragoangel
Copy link
Contributor Author

@ribbybibby as I understand your code support regex there and should work like a charm, right?

@ribbybibby
Copy link
Owner

@dragoangel Thanks for the PR! Could you please update the tests to check this works?

@dragoangel
Copy link
Contributor Author

@dragoangel Thanks for the PR! Could you please update the tests to check this works?

Will check ✅🙂

@dragoangel
Copy link
Contributor Author

@ribbybibby can you please check? Hope it okay :D

prober/tcp_test.go Outdated Show resolved Hide resolved
test/tcp.go Outdated Show resolved Hide resolved
dragoangel and others added 2 commits March 21, 2024 17:03
Co-authored-by: Rob Best <robertbest89@gmail.com>
@ribbybibby ribbybibby merged commit 3424423 into ribbybibby:master Mar 22, 2024
2 checks passed
@dragoangel
Copy link
Contributor Author

@ribbybibby can you please issue a release? :) Would like to pull image with this changes 🙏

@dragoangel dragoangel deleted the patch-1 branch March 22, 2024 12:32
@dragoangel
Copy link
Contributor Author

@ribbybibby can you please issue a release? :) Would like to pull image with this changes 🙏

@ribbybibby sorry for pinging, but can you please create release with this changes?

@ribbybibby
Copy link
Owner

@dragoangel v2.4.3 has been released

@dragoangel
Copy link
Contributor Author

@dragoangel v2.4.3 has been released

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants