Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

switch to commonjs #1

Closed
ncfx opened this issue May 31, 2016 · 4 comments
Closed

switch to commonjs #1

ncfx opened this issue May 31, 2016 · 4 comments

Comments

@ncfx
Copy link

ncfx commented May 31, 2016

Please switch to commonjs so it can support webpack

@ribizli
Copy link
Owner

ribizli commented May 31, 2016

What about this solution? https://webpack.github.io/docs/code-splitting.html#es6-modules
(referenced from here: http://stackoverflow.com/questions/36103641/dynamic-system-import-with-webpack). I'm not familiar with webpack, so I appreciate your feedback.
Since sytemjs can consume commonjs packages, it won't be a problem to change it, if the above cannot solve your issue. But I have no time to do this in a the next weeks, sorry.

@ncfx
Copy link
Author

ncfx commented May 31, 2016

no worries, I can wait :)

If you have time, you can edit and commit the tsconfig.json right in github, too :)

@ribizli
Copy link
Owner

ribizli commented May 31, 2016

Can't you try and consume it the above mentioned way?

Editing the tsconfig.json is not all I need to do, e.g. publishing to npm...

@ribizli ribizli closed this as completed Aug 29, 2016
@ribizli
Copy link
Owner

ribizli commented Aug 29, 2016

fixed by #2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants