Extract model class methods #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move them to a separate module. Keep the AttrMasker module clean and minimal.
houndci-bot
reviewed
Aug 4, 2017
lib/attr_masker/model.rb
Outdated
| }.merge!(attr_masker_options).merge!(attributes.last.is_a?(Hash) ? attributes.pop : {}) | ||
|
|
||
| attributes.each do |attribute| | ||
| masker_attributes[attribute.to_sym] = Attribute.new(attribute, self, options) |
lib/attr_masker/model.rb
Outdated
| :dump_method => "dump", | ||
| :load_method => "load", | ||
| :masker => AttrMasker::Maskers::SIMPLE, | ||
| }.merge!(attr_masker_options).merge!(attributes.last.is_a?(Hash) ? attributes.pop : {}) |
| :marshaler => Marshal, | ||
| :dump_method => "dump", | ||
| :load_method => "load", | ||
| :masker => AttrMasker::Maskers::SIMPLE, |
| :marshal => false, | ||
| :marshaler => Marshal, | ||
| :dump_method => "dump", | ||
| :load_method => "load", |
| :column_name => nil, | ||
| :marshal => false, | ||
| :marshaler => Marshal, | ||
| :dump_method => "dump", |
lib/attr_masker/model.rb
Outdated
| def attr_masker(*attributes) | ||
| options = { | ||
| :if => true, | ||
| :unless => false, |
lib/attr_masker/model.rb
Outdated
| # See README for more examples | ||
| def attr_masker(*attributes) | ||
| options = { | ||
| :if => true, |
lib/attr_masker/model.rb
Outdated
| # @user.masker_configuration # returns the masker version of configuration | ||
| # | ||
| # See README for more examples | ||
| def attr_masker(*attributes) |
lib/attr_masker/model.rb
Outdated
| # | ||
| # class User | ||
| # # now all attributes will be encoded and marshaled by default | ||
| # attr_masker_options.merge!(:marshal => true, :some_other_option => true) |
lib/attr_masker/model.rb
Outdated
| def self.extended(base) # :nodoc: | ||
| base.class_eval do | ||
| attr_writer :attr_masker_options | ||
| @attr_masker_options, @masker_attributes = {}, {} |
|
Reported Hound violations come from the original code. EDIT: Fixed anyway. |
Avoid lines which are too long.
skalee
force-pushed
the
move-class-methods
branch
2 times, most recently
from
86e60b9
to
3e163bf
Compare
houndci-bot
reviewed
Aug 4, 2017
| # @user.masker_configuration # returns the masker version of configuration | ||
| # | ||
| # See README for more examples | ||
| def attr_masker(*args) |
Rewrite the method to make it more readable and fix most of code style violations.
skalee
force-pushed
the
move-class-methods
branch
from
3e163bf
to
d37d2de
Compare
Here hash rockets make things more readable.
skalee
force-pushed
the
move-class-methods
branch
from
d37d2de
to
87d5c35
Compare
|
@skalee this is very good. Could we also change to the 1.9 hash syntax and also document using RubyDocs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move class methods to a separate
AttrMasker::Modelmodule, keep theAttrMaskermodule as minimal and simple as possible.