Pass 'model_instance' as 'model:' into custom masker's Proc #58
Conversation
spec/features/shared_examples.rb
Outdated
| expect { run_rake_task }.not_to(change { User.count }) | ||
|
|
||
| expect { han.reload }.to( | ||
| change { han.first_name }.to("naHhan@example.test") & |
There was a problem hiding this comment.
Indent the first parameter one step more than the start of the previous line.
| @@ -34,7 +34,7 @@ def should_mask?(model_instance) | |||
| # returning. | |||
| def mask(model_instance) | |||
| value = unmarshal_data(model_instance.send(name)) | |||
| masker_value = options[:masker].call(options.merge!(value: value)) | |||
| masker_value = options[:masker].call(options.merge!(value: value, model: model_instance)) | |||
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 99.4% 99.39% -0.01%
==========================================
Files 23 23
Lines 334 332 -2
==========================================
- Hits 332 330 -2
Misses 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 99.4% 99.39% -0.01%
==========================================
Files 23 23
Lines 334 333 -1
==========================================
- Hits 332 331 -1
Misses 2 2
Continue to review full report at Codecov.
|
ribose-jeffreylau
force-pushed
the
model-proc
branch
from
d873ba8
to
b3d00cf
Compare
|
Thanks @ribose-jeffreylau ! |
This allows for something like this:
Ref #5