Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails 6 #75

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Add support for Rails 6 #75

merged 4 commits into from
Jan 28, 2020

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Jan 28, 2020

  • Relax dependency constraints
  • Update test suite for changes in ActiveSupport::DescendantsTracker in Rails 6
  • Test against Rails 6 in Travis CI

@skalee
Support Rails 6.x
2f4ae5d
@skalee
Relax SQLite3 development dependency constraint
e74095d 
However, in order to avoid compatibility issues, use version 1.3.x
when testing against Rails 4.2 and 5.x in CI.
@skalee
Don't hack into descendants tracker in specs
74d9142 
Active Support features its own class hierarchy tracker, which was
preventing anonymous classes from being garbage collected due to
a bug, which has been fixed in Rails 6.0.

For older Rails version, a hack is needed to make tests independent
from each other.  For Rails 6+, this hack no longer works, but is
also unnecessary.  Although another workaround is needed.  See comment
in the Ruby changeset for details.
@skalee
Rearrange Travis CI build matrix
511a11e 
Test against Rubies 2.2–2.7 and Rails 4.2–6.0 as before, but properly
avoid unsupported Ruby+Rails combinations.
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #75 into master will increase coverage by 36.47%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
+ Coverage   62.34%   98.82%   +36.47%     
===========================================
  Files          25       23        -2     
  Lines         555      339      -216     
===========================================
- Hits          346      335       -11     
+ Misses        209        4      -205
Impacted Files Coverage Δ
spec/features/mongoid_spec.rb 89.47% <0%> (-10.53%) ⬇️
spec/spec_helper.rb
spec/features/shared_examples.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff78a3...511a11e. Read the comment docs.

@skalee skalee merged commit db2c60d into master Jan 28, 2020
@skalee skalee deleted the rails-6 branch January 28, 2020 11:37
@skalee
Copy link
Contributor Author

skalee commented Jan 28, 2020

Fixes #70.

This was referenced Jan 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skalee