Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework what arguments are passed to maskers #92

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Feb 3, 2020

  • For clarity and predictability, pass all attr_masker options to masker in a single hash.
  • Pass the attribute name as well.
  • Add specs for that, and for Attribute#mask method in general.

- For clarity and predictability, pass all attr_masker options
  to masker in a single hash.
- Pass the attribute name as well.
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #92 into master will increase coverage by 37.66%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #92       +/-   ##
===========================================
+ Coverage   61.78%   99.45%   +37.66%     
===========================================
  Files          26       24        -2     
  Lines         560      366      -194     
===========================================
+ Hits          346      364       +18     
+ Misses        214        2      -212
Impacted Files Coverage Δ
lib/attr_masker/attribute.rb 100% <100%> (ø) ⬆️
spec/unit/attribute_spec.rb 100% <100%> (ø) ⬆️
spec/spec_helper.rb
spec/features/shared_examples.rb
spec/features/mongoid_spec.rb 100% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce89716...49be6b7. Read the comment docs.

@skalee skalee merged commit a585282 into master Feb 3, 2020
@skalee skalee deleted the better-masker-options branch February 3, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant