Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix GHA issues during preparation #97

Merged
merged 2 commits into from
Sep 1, 2020
Merged

ci: Fix GHA issues during preparation #97

merged 2 commits into from
Sep 1, 2020

Conversation

ribose-jeffreylau
Copy link
Contributor

@ribose-jeffreylau ribose-jeffreylau changed the title ci: Try to remove mongodb-org prior to installing mongodb ci: Fix GHA issues during preparation Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #97 into master will increase coverage by 35.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #97       +/-   ##
===========================================
+ Coverage   64.00%   99.45%   +35.45%     
===========================================
  Files          26       24        -2     
  Lines         589      369      -220     
===========================================
- Hits          377      367       -10     
+ Misses        212        2      -210     
Impacted Files Coverage Δ
lib/attr_masker/attribute.rb 100.00% <ø> (ø)
lib/attr_masker/maskers/replacing.rb 100.00% <ø> (ø)
lib/attr_masker/maskers/simple.rb 100.00% <ø> (ø)
spec/spec_helper.rb
spec/features/shared_examples.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f904637...21606d2. Read the comment docs.

@ronaldtse
Copy link
Contributor

@ribose-jeffreylau there is some issue with the gem spec versions:

Bundler could not find compatible versions for gem "activerecord":
18
  In Rails-4.2.gemfile:
19
    activerecord (~> 4.2.0)
20

21
    attr_masker was resolved to 0.2.1, which depends on
22
      rails (>= 4.0.0, < 7) was resolved to 5.0.5.rc1, which depends on
23
        activerecord (= 5.0.5.rc1)
24

@ronaldtse
Copy link
Contributor

I'm going to merge this for now and mark a new bug for Rails 4.2 with Ruby 2.4, 2.5 and 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants