adding basic user verfication while signup

ric03uec · Aug 23, 2012 · 85376f0 · 85376f0
1 parent c2d79b2
commit 85376f0
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 24 deletions.
diff --git a/public/js/signup.js b/public/js/signup.js
@@ -14,10 +14,12 @@ Signup.submitForm = function(){
   };
   //run some basic validations
   $.post('/signup', {'signupForm' : signupForm}, function(response){
+      console.log(response);
     if(response.retStatus === 'success'){
-      Signup.showMessage($('#signupMessage'), 'Successfully Logged in', true);
+      Signup.showMessage($('#signupMessage'), 'Successfully Signed up ', true);
+      $(location).attr('href', '/admin');
     }else{
-      Signup.showMessage($('#signupMessage'), 'Error Loggin in : ' + response.message, false);
+      Signup.showMessage($('#signupMessage'), 'Error Creating New User : ' + response.message, false);
     }
   });
 };

diff --git a/routes/index.js b/routes/index.js
@@ -18,6 +18,21 @@ var getAllMeta = function(req, res, next){
   });
 };
 
+/**
+  * validate the signup credentials entered by the user
+  * @param {String} username 
+  * @param {String} pass1 : first password
+  * @param {String} pass2 : verification password
+  */
+var validateUserData = function(username, pass1, pass2){
+  if(pass1.trim() !== pass2.trim()){
+    util.log('Passwords not Matching ' + pass1 + ' ' + pass2);
+    return 'Passwords not Matching';
+  }
+  return '';
+  //put any other validations here
+};
+
 /*
  * GET home page.
  */
@@ -51,6 +66,7 @@ module.exports = function(app){
           retStatus : 'failure'  
         });
       }else{
+        console.log(user);
         req.session.user = user;
         res.json({
           retStatus : 'success',
@@ -79,30 +95,38 @@ module.exports = function(app){
     var pass1 = signupForm.pass1;
     var pass2 = signupForm.pass2;
 
-    util.log('Username ' + username + '   Pass ' + pass1);
-
-    //run all the input validations here. accept as it is right now
-    var newUser = new User();
-    newUser.username = username;
-    newUser.password = pass1;
-
-    newUser.save(function(err, response){
-      var message = '';
-      var retStatus = '';
-      if(!err){
-        util.log('Successfully created new user with Username : ' + username);
-        message = 'Successfully created new user : ' + username;
-        retStatus = 'success';
-      }else{
-        util.log('Error while creating user : ' + username + ' error : ' + util.inspect(err));
-        message = 'Error while creating new user : ' + username + ' ' + err.message;
-        retStatus = 'failure';
-      }
+    var validateMsg = validateUserData(username, pass1, pass2);
+    if(validateMsg !== ''){
       res.json({
-        'retStatus' : retStatus,
-        'message' : message
+        'retStatus' : 'failure',
+        'message' : validateMsg
       });
-    });
+    }else{
+      var newUser = new User();
+      newUser.username = username;
+      newUser.password = pass1;
+
+      newUser.save(function(err, savedUser){
+        var message = '';
+        var retStatus = '';
+        if(!err){
+          util.log('Successfully created new user with Username : ' + username);
+          message = 'Successfully created new user : ' + username;
+          retStatus = 'success';
+          req.session.user = savedUser;
+        }else{
+          util.log('Error while creating user : ' + username + ' error : ' + util.inspect(err));
+          if(err.code === 11000){
+            message = "User already exists";
+          }
+          retStatus = 'failure';
+        }
+        res.json({
+          'retStatus' : retStatus,
+          'message' : message
+        });
+      });
+    }
   });
 
   app.get('/admin', getAllMeta, function(req, res){