Add zoomSpeed-prop and use it to multiply the wheelzoom #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
reviewed
Jan 8, 2019
| @@ -169,7 +169,7 @@ class Cropper extends React.Component { | |||
| onWheel = e => { | |||
| e.preventDefault() | |||
| const point = Cropper.getMousePoint(e) | |||
| const newZoom = this.props.zoom - e.deltaY / 200 | |||
| const newZoom = this.props.zoom - (e.deltaY * this.props.zoomSpeed) / 200 | |||
There was a problem hiding this comment.
I don't really like the hardcoded 200 value. Do you think we could combine it with the zoomSpeed property (and keep "approximatively" the same behavior as today)?
There was a problem hiding this comment.
I don't see, how we can combine this.
We could extract the hardcoded number to a class constant, but this is out of scope of this PR in my opinion.
|
Thanks for this PR 🙂 |
|
Released as 1.7.0: https://github.com/ricardo-ch/react-easy-crop/releases/tag/v1.7.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a "zoomSpeed"-prop, which basically just multiplies the deltaY of a mousewheel-turn before adding it to the previous zoom.
closes #20