Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list/map mutation functions #39

Merged
merged 20 commits into from
Sep 4, 2023

Conversation

ricardoboss
Copy link
Owner

@ricardoboss ricardoboss commented Sep 1, 2023

Fixes #38

  • doAdd: Adds the given element to the end of the list.
    • Documentation
    • Tests
  • doRemove: Removes the first occurrence of the given element from the list.
    • Documentation
    • Tests
  • doPop: Removes the last element from the list and returns it.
    • Documentation
    • Tests
  • doShift: Removes the first element from the list and returns it.
    • Documentation
    • Tests
  • [ ] doUnshift: Adds the given element to the front of the list.
  • doRemoveAt: Removes the element at the given index/key from a list/map.
    • Documentation
    • Tests
  • doInsertAt: Inserts the given element at the given index in the list.
    • Documentation
    • Tests
  • doSwap: Swaps the elements at the given indices in a list or the values at the given keys in a map.
    • Documentation
    • Tests

Decided to not implement doUnshift as the same behaviour can be achieved using doInsertAt(0, <value>).

@ricardoboss ricardoboss linked an issue Sep 1, 2023 that may be closed by this pull request
@ricardoboss ricardoboss force-pushed the issues/38-list-map-mutation-functions branch from e26e648 to cad5c6d Compare September 4, 2023 16:53
@ricardoboss ricardoboss marked this pull request as ready for review September 4, 2023 18:22
@ricardoboss ricardoboss force-pushed the issues/38-list-map-mutation-functions branch 2 times, most recently from 72386b3 to 9668087 Compare September 4, 2023 21:01
ricardoboss and others added 20 commits September 4, 2023 23:29
Enhancements were made for the equality and comparison checks of various Expression Result classes including MapResult, StringResult, ListResult, BoolResult, FunctionResult, NumberResult, NullResult, and VoidResult. A new abstract class ComparableValueExpressionResult is introduced for results that can be compared. These updates facilitate better result comparison which is essential in many logical operations.
@ricardoboss ricardoboss force-pushed the issues/38-list-map-mutation-functions branch from e924719 to 374d5b9 Compare September 4, 2023 21:36
@ricardoboss ricardoboss merged commit 87c978a into main Sep 4, 2023
10 checks passed
@ricardoboss ricardoboss deleted the issues/38-list-map-mutation-functions branch September 4, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list/map mutation functions
1 participant