Bugfix: always wrote "ETA: 00:00:00" #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d writting "ETA: 00:00:00" all along. The to_s.to_i was always returning 200 even if the to_s was returning "1234567".
joelvh
added a commit
to joelvh/taps2
that referenced
this pull request
Mar 29, 2017
|
Achievement unlocked, you earn the badge :necromancer: ! |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Integer() instead of to_i to fix a bug using Heroku cli that ended writting "ETA: 00:00:00" all along.
The to_s.to_i was always returning 200 even if the to_s was returning "1234567".