Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Something went wrong internally, reopen and no worries" #179

Closed
corysimmons opened this issue Apr 18, 2017 · 14 comments
Closed

"Something went wrong internally, reopen and no worries" #179

corysimmons opened this issue Apr 18, 2017 · 14 comments

Comments

@corysimmons
Copy link

atom/atom#14248

Happens really frequently for no discernible reason.

@damon-kreft
Copy link

damon-kreft commented Apr 19, 2017

Yeah same here. Consistently the the very first time I open Atom and my first JS file, whether standard is in devDependencies or not...

screen shot 2017-04-19 at 02 52 25

Here are my Atom settings/packages: https://gist.github.com/damon-kreft/9801de58dce368df4f06b917f317559a

@dcalhoun
Copy link

dcalhoun commented Apr 19, 2017

I can confirm this warning displays when opening the first JavaScript file after creating a new Atom window. It happens every time consistently. After the first JavaScript file is open, the warning does not appear again until I create a new Atom window (i.e. the warning does not display for the 2nd, 3rd, 4th, etc JavaScript file).

Environment

  • Atom 1.16.0
  • linter 2.1.4
  • linter-ui-default 1.2.3
  • linter-js-standard 3.9.0
  • standard 10.0.1

@mattfysh
Copy link

mattfysh commented May 5, 2017

I don't know enough about atom internals but it looks like this.cache.get('text-editor', ... inside of linter-js-standard.js is being trigger before the call to this.cache.set... in init.js

@dcalhoun
Copy link

This is a duplicate of #126 and should likely be closed.

@whaaaley
Copy link

@dcalhoun i think this issue differs because:

  • it happens on just the first file opened
  • only one error appears
  • only happens after you start atom and open a file

@pablomayobre
Copy link

I had this same issue, as @whaaaley explained, it started to happen after my configuration was reset (for some other problem I'm guessing).

I cannot reproduce this consistently though

@revelt
Copy link

revelt commented Jun 20, 2017

Confirmed, it's happening exactly as @whaaaley described. First open of first JS file. Subsequent opens won't trigger the error. I can recreate it, just close the window, open some project, click on the tree view on any JS file, error will appear.

It will appear again and again if you won't double-click-open one JS file and close it. After closing, it does not appear on that window any more.

@revelt
Copy link

revelt commented Jun 20, 2017

Switching to an alternative Standard linter, linter-js-standard-engine solved this for me.

@whaaaley
Copy link

@revelt Looks nice, however it looks like everything is an error rather than having some warnings, but that's much more tolerable than a message window. I'll be using this from now on too.

@whaaaley
Copy link

@revelt Looks like that project doesn't have html support or support for a global install or a default engine... all of those things are kind of a bummer for me. I might go digging later and try to fix this.

@whaaaley
Copy link

Looks like the PR by @educcjr fixes this! I just cloned and tested it out.

@sonicdoe
Copy link
Collaborator

This will be fixed in an upcoming patch version.

@sonicdoe
Copy link
Collaborator

Released in v3.9.2 🎉

@revelt
Copy link

revelt commented Jul 28, 2017

I can confirm 3.9.2 works perfectly. Thanks everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants