Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEmbedUrl should return secure url (optionnaly ?) #4

Closed
adriantombu opened this issue Mar 17, 2016 · 4 comments
Closed

getEmbedUrl should return secure url (optionnaly ?) #4

adriantombu opened this issue Mar 17, 2016 · 4 comments

Comments

@adriantombu
Copy link

Hi !
As the web migrates more and more to the HTTPS everywhere, it should be interesting to offer the user the choice to get an https embed when calling getEmbedUrl()
Maybe by forcing it, or simply adding a $secure = false var in the function call.
The main problem here is when you want to display an http only embed on a https url, the video is just blocked by the browser. And that's a problem, isn'it ? 😆

edit: the same goes for the getLargestThumbnail(), I guess

@ricardofiorani
Copy link
Owner

Hi Adrian, I agree with you and that's a great suggestion. I'll look into it.

@adriantombu
Copy link
Author

Great ! I would have proposed something if only I had the time to !

@ricardofiorani
Copy link
Owner

@adriantombu your suggestion is available in release v0.3.1. Thank you for taking the time to open this issue.

@adriantombu
Copy link
Author

Hey ! Thanks for fast implementation :)

ricardofiorani added a commit that referenced this issue Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants