Usage of a function in loops should be avoided.

ricardonavarrom · Oct 9, 2016 · 877e256 · 877e256
1 parent d7e4173
commit 877e256
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/VATINValidator/Validator/VATINValidatorES.php b/src/VATINValidator/Validator/VATINValidatorES.php
@@ -68,7 +68,8 @@ public function validate($vatin, $allowLowerCase = true)
     private function getCIFPairSum($centralDigits)
     {
         $pairSum = 0;
-        for ($i = 1; $i < strlen($centralDigits); $i += 2) {
+        $centralDigitsNum = strlen($centralDigits);
+        for ($i = 1; $i < $centralDigitsNum; $i += 2) {
             $pairSum += (int)$centralDigits[$i];
         }
 
@@ -78,7 +79,8 @@ private function getCIFPairSum($centralDigits)
     private function getCIFOddDoubleSum($centralDigits)
     {
         $oddDoubleSum = 0;
-        for ($i = 0; $i < strlen($centralDigits); $i += 2) {
+        $centralDigitsNum = strlen($centralDigits);
+        for ($i = 0; $i < $centralDigitsNum; $i += 2) {
             $oddDoubleSum += (int)array_sum(str_split($centralDigits[$i] * 2));
         }