Dev quant 1480 #733
Merged
Dev quant 1480 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuizi7
reviewed
Sep 2, 2022
| @@ -228,7 +229,7 @@ def contract_multiplier(self): | |||
| @property | |||
| @lru_cache() | |||
There was a problem hiding this comment.
顺手把这里的 property 改成 utils 中的 cached_property 吧
Cuizi7
reviewed
Sep 2, 2022
rqalpha/portfolio/position.py
Outdated
| if not is_valid_price(self._prev_close): | ||
| env = Environment.get_instance() | ||
| self._prev_close = env.data_proxy.get_prev_close(self._order_book_id, env.trading_dt) | ||
| if not is_valid_price(self._prev_close) or self._cur_trading_date is None or self._cur_trading_date < self._env.trading_dt.date(): |
There was a problem hiding this comment.
这太复杂了，而且每次取 prev_close 做这么多判断性能也比较差，直接在 before_trading 中把 self._prev_close 清理掉吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.