Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Web Workers by using the global btoa #269

Merged
merged 3 commits into from Jan 31, 2024

Conversation

curran
Copy link
Contributor

@curran curran commented Jan 20, 2024

Fix #268

@antfu antfu changed the title Support Web Workers feat: support Web Workers by using the global btoa Jan 20, 2024
@antfu
Copy link
Collaborator

antfu commented Jan 20, 2024

Tests are failing. Maybe we could check globalThis.btoa instead?

@curran
Copy link
Contributor Author

curran commented Jan 31, 2024

@antfu I think the tests should be passing now. Thanks for the feedback!

@antfu antfu merged commit 8679648 into Rich-Harris:master Jan 31, 2024
12 checks passed
@curran
Copy link
Contributor Author

curran commented Jan 31, 2024

Hooray! Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails in Web Worker
2 participants