Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refer to issue #15 #16

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

refer to issue #15 #16

wants to merge 18 commits into from

Conversation

mrofi
Copy link

@mrofi mrofi commented Jan 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #16    +/-   ##
========================================
  Coverage       100%   100%            
- Complexity      107    143    +36     
========================================
  Files            14     19     +5     
  Lines           283    397   +114     
========================================
+ Hits            283    397   +114
Impacted Files Coverage Δ Complexity Δ
src/Commands/RouteTranslationsCacheCommand.php 100% <100%> (ø) 9 <9> (?)
src/ServiceProvider.php 100% <100%> (ø) 8 <2> (+2) ⬆️
src/Traits/TranslatedRouteCommandContext.php 100% <100%> (ø) 7 <7> (?)
src/Commands/RouteTranslationsListCommand.php 100% <100%> (ø) 7 <7> (?)
src/Commands/RouteTranslationsClearCommand.php 100% <100%> (ø) 5 <5> (?)
src/I18nService.php 100% <100%> (ø) 26 <0> (ø) ⬇️
src/Traits/LoadsTranslatedCachedRoutes.php 100% <100%> (ø) 6 <6> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed5c00...de5c28d. Read the comment docs.

@mrofi mrofi mentioned this pull request Jan 16, 2020
@scrutinizer-notifier
Copy link

The inspection completed: 6 new issues, 27 updated code elements

@richan-fongdasen richan-fongdasen self-assigned this Feb 25, 2020
@richan-fongdasen richan-fongdasen linked an issue Feb 25, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routes Cache Issue
3 participants