-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication #69
Merged
richardartoul
merged 37 commits into
richardartoul:master
from
aratz-lasa:feature/replication
May 22, 2023
Merged
Replication #69
richardartoul
merged 37 commits into
richardartoul:master
from
aratz-lasa:feature/replication
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aratz-lasa
commented
May 13, 2023
aratz-lasa
commented
May 13, 2023
aratz-lasa
commented
May 13, 2023
richardartoul
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small nits but ill fix them in a manual push to master
Fixing nits here: https://github.com/richardartoul/nola/pull/77/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This pull request implements actor replication in the NOLA system. The main goal is to ensure actors' availability and load balancing by replicating them across multiple servers. The code diff includes the following changes:
EnsureActivation
method in thekvRegistry
struct to improve readability and maintainability.pickServersForActivation
to select multiple servers, instead of a single one, for actor activation based on various criteria such as memory usage, activation count, blacklisting, and caching.pickServersForActivation
function to randomly choose the servers for actor activation.ExtraReplicas
field to theEnsureActivationRequest
struct. This field specifies the desired number of additional replicas to be created during actor activation in addition to the primary replica.ExtraReplicas
field from theActorOptions
struct to theEnsureActivationRequest
struct. This change aligns the field with its usage in theEnsureActivation
method and ensures consistency in the codebase.Additionally, the code changes include improvements to handle server blacklisting in the
ensureActivation
method. The logic ensures that if the current request specifies blacklisted servers and any of those servers are not marked as blacklisted in the cache, the cache is refreshed to prevent routing back to blacklisted server IDs. The code also filters the cached references to exclude blacklisted servers for subsequent processing.Most interesting files to review:
virtual/registry/kvregistry.go
virtual/activation_cache.go
virtual/environment.go