Propagate Context Deadlines over RPCs by Adding Header #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aratz-lasa
changed the title
examples/leaderregistry/main_test.go
Outdated
| ReplicationStrategy: types.ReplicaSelectionStrategyRandom, | ||
| }} | ||
|
|
||
| // Use require.Eventually to invoke the actor until it is replicated in all available servers. |
There was a problem hiding this comment.
Its not really clear why this is important. I assume you want to guarantee it reached two different servers to ensure at least one of your requests went over the network right? Can you comment that? Also make sure that ForceRemoteProcedureCalls is enabled and call that out in the comment as well
richardartoul
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to address issue #82, which relates to the loss of context deadlines when performing RPCs over the network using the HTTP client. The proposed solution is to propagate the context deadline as a header in the HTTP requests, ensuring that the deadlines are preserved throughout the network communication.
The following changes have been made to achieve this:
Created a new constant
HttpHeaderTimeoutinvirtual/types/http.goto define the custom header name for context timeouts in HTTP requests.Added a new function
getContextFromRequestin thevirtual/server.gofile to extract the timeout value from the request header. This enables the propagation of context deadlines in HTTP headers.Updated the
InvokeActorRemotefunction invirtual/client.goto include the context deadline as a header in the HTTP requests.