Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGifCloseFile signature changed: fixes build against giflib 5.1.0 #44

Closed
wants to merge 2 commits into from

Conversation

devsnd
Copy link

@devsnd devsnd commented Jun 15, 2014

I just tried to build skippy-xd on arch linux, but it failed (even though it did work 2 days ago).

I'm using this package build in the user repository:
https://aur.archlinux.org/packages/skippy-xd-git/

I'm not sure about the versioning of libgif, but this patch is necessary for skippy-xd to compile and work at least on arch.

Here's the line in the giflib header:
http://sourceforge.net/p/giflib/code/ci/master/tree/lib/gif_lib.h#l183

@richardgv richardgv closed this in 998e0e7 Jun 18, 2014
@richardgv
Copy link
Owner

Thanks for the patch, devsnd! And sorry for not replying in 3 days.

The API breakage is in giflib-5.1.0, not in giflib-5.0.x, so unfortunately we need to introduce another macro to deal with this... Could you please test if 998e0e7 fixes the issue?

@devsnd
Copy link
Author

devsnd commented Jun 18, 2014

Hi Richard,

I just tried it out and it works fine. Thanks!

@richardgv
Copy link
Owner

Great, thanks for testing! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants