fix(equality): allow different currencies for .eq and .ne

Testing for equality should not throw whe the currencies are different.
richardschneider · Nov 17, 2016 · 46b14ea · 46b14ea
1 parent f2a44c6
commit 46b14ea
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/lib/money.js b/lib/money.js
@@ -121,11 +121,11 @@ Money.prototype.compare = function compare(that) {
 };
 
 Money.prototype.eq = function eq(that) {
-    return this.compare(that) === 0;
+    return this.currency === that.currency && this.compare(that) === 0;
 };
 
 Money.prototype.ne = function ne(that) {
-    return this.compare(that) !== 0;
+    return this.currency !== that.currency || this.compare(that) !== 0;
 };
 
 Money.prototype.lt = function lt(that) {

diff --git a/test/money.js b/test/money.js
@@ -243,6 +243,24 @@ describe('Money', () => {
             new Money(1, 'NZD').isNegative().should.equal(false);
         });
 
+        it('should return false when currencies are different and testing equality', () => {
+            let a = new Money(30, 'NZD');
+            let b = new Money(30, 'NZD');
+            let c = new Money(30, 'USD');
+
+            a.eq(b).should.equal(true);
+            a.eq(c).should.equal(false);
+        });
+
+        it('should return true when currencies are different and testing inequality', () => {
+            let a = new Money(30, 'NZD');
+            let b = new Money(30, 'NZD');
+            let c = new Money(30, 'USD');
+
+            a.ne(b).should.equal(false);
+            a.ne(c).should.equal(true);
+        });
+
     });
 
     describe('Serialisation', () => {