Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update should to the latest version 馃殌 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Aug 28, 2017

Version 12.0.0 of should just got published.

Dependency should
Current Version 11.2.1
Type devDependency

The version 12.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of should.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes Better Map Set equality

Map/Set/WeakMap/WeakSet equality checks

User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.
Typical example that was working before this release:

const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);

m1.should.be.eql(m2)

And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:

const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);

m1.should.be.eql(m2)

This example is not that clear if it should assert or not, right? (it should).

As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.

Consistency in bundles

For the long time (probably several years now) browser bundle and node bundle has little differences in globals.
To make them sync i am doing such changes to bundles:

  1. Browser bundle will not contain window.Should any more (with capital S). It was deprecated for the long time. Just use window.should as is.
  2. Node bundle change global.should to be should function instead of getter attached to Object.prototype.
Commits

The new version differs by 12 commits.

  • 52dc121 Release 12.0.0
  • 6c1e6bd Prettier all
  • 6114e76 Update years
  • 670df30 Merge branch 'master' of github.com:shouldjs/should.js
  • ecf8033 Update tools
  • e4d0acc Normalize entry points
  • f4adabb Set zuul to use 2 last versions of browsers
  • 8114b5d Merge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual
  • 02ec6a0 fix error message for aboveOrEqual & belowOrEqual
  • 031888e Merge pull request #140 from carldunham/feature/cd/add-equals-eqls
  • 1e4909b Add for readability: equals, eqls
  • 4a53d94 Release 11.2.1

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3e7e500 on greenkeeper/should-12.0.0 into 0c684db on master.

greenkeeper bot added a commit that referenced this pull request Sep 5, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 5, 2017

Version 13.0.0 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 11 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Sep 6, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 6, 2017

Version 13.0.1 just got published.

Update to this version instead 馃殌

Release Notes 13.0.1

Add back missing umd build in root of package

Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Sep 20, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 20, 2017

Version 13.1.0 just got published.

Update to this version instead 馃殌

Release Notes 13.1.0

New

  1. Now all zero argument assertions throw TypeError in case any argument passed to them.
  2. Aliased .fulfill/.fulfilledWith to .resolve/.resolvedWith`

Fixes

  1. TS definition fixed to allow such imports:
import should from 'should';
Commits

The new version differs by 6 commits.

  • c807e9d Release 13.1.0
  • 8acfba1 Merge pull request #154 from citizensas/master
  • c12afd0 chore: should has no default export
  • 4a846b1 Fill history
  • f5c9cc3 Added check for zero argument assertions.
  • fe6b136 Added .resolved, .resolvedWith as aliases to .fulfilled, .fulfilledWith

See the full diff

greenkeeper bot added a commit that referenced this pull request Oct 7, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Oct 7, 2017

Version 13.1.1 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Oct 10, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Oct 10, 2017

Version 13.1.2 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 2 commits.

  • ff0877a Release 13.1.2
  • 6c8cb39 Revert typings to use = instead of default export. Fixes #155

See the full diff

greenkeeper bot added a commit that referenced this pull request Oct 28, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Oct 28, 2017

Version 13.1.3 just got published.

Update to this version instead 馃殌

Release Notes 13.1.3

Fix #157

Commits

The new version differs by 5 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Dec 27, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 27, 2017

Version 13.2.0 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 3 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jan 12, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 12, 2018

Version 13.2.1 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jul 26, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jul 26, 2018

Version 13.2.2 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 9 commits.

  • 031b8e6 Release 13.2.2
  • 6db456c Merge branch 'master' of github.com:shouldjs/should.js
  • 1ab1661 Add note about TS
  • 889e22e Merge pull request #171 from jsoref/spelling
  • 79ec809 Spelling fixes
  • 0abf2d5 Merge pull request #167 from lumaxis/bugfix/typescript-error
  • d1e9efe Fix TypeScript compiler issue with fulfilled assertion
  • 9dcde0f Merge pull request #164 from chris-grabcad/UpdateDefinitionsOfTrueAndFalseInTypings
  • 7917c9c Add optional message to [Tt]rue and [Ff]alse so they can be used in typecript tests

See the full diff

greenkeeper bot added a commit that referenced this pull request Jul 30, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jul 30, 2018

Version 13.2.3 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 2 commits.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant