Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dot indicators to represent events on a date. #95

Open
jameswwwebster opened this issue Sep 28, 2017 · 15 comments
Open

Comments

@jameswwwebster
Copy link
Contributor

On the Apple calendar, on month view, each day can have a dot underneath the date to represent the presence or absence of an event. This isn't present on the day view on the Apple Calendar, however I think that it is something the top week-banner could benefit from and could be added to this library.

This is a feature that I plan to implement myself and submit as a pull request, however it would be good if there could be some feedback about potential pitfalls or suggested implementation before any work is done.

@richardtop
Copy link
Owner

It's definitely a good idea.
Few suggestions / possible solutions, that I have in mind:

  1. It's possible to turn this feature on and off by setting a property in DaySelectorStyle.
  2. The property, in its turn, will enable the feature in DateLabel.
  3. All the changes in style will be propagated through CalendarStyle NSCopying protocol.

Another idea is to change Header to use UICollectionView or implement a design similar to it. So, for example, to register custom cells.

@vgyan
Copy link

vgyan commented Sep 29, 2017

Good One.. Waiting for this

@lincolntran
Copy link

@jameswwwebster Are you still working on this? I'm planning to implement it myself, but don't want to duplicate the work.

Thanks

@jameswwwebster
Copy link
Contributor Author

@lincolntran, No, I never got the chance to start on this.

@lincolntran
Copy link

Ok, I'll do it then if you don't mind.

@jameswwwebster
Copy link
Contributor Author

Of course! :) This is the brilliance of open source software, everybody can contribute.

@sinisa503
Copy link

Did you work something on this? I have implemented this feature in my project but I did not put this code here because It's not made for framework but project specific. Maybe I can get involved if you need...

@jameswwwebster
Copy link
Contributor Author

jameswwwebster commented Jan 3, 2018 via email

@ankitjaiswal1994
Copy link

@sinisa503 Could you please help us if you have already did this ?

@ysaucedo
Copy link

ysaucedo commented Sep 9, 2019

I need this functionality, I can cooperate with money who makes the adjustment

@ankitjaiswal1994
Copy link

@ysaucedo If you need something like below attachment I can help you without money.
Simulator Screen Shot - iPhone 6 - 2019-09-10 at 19 11 26
Simulator Screen Shot - iPhone 6 - 2019-09-10 at 19 11 27

@ysaucedo
Copy link

@ankitjaiswal1994

Hi! It's what i'm looking for,
Can you share the control you mention?

@ankitjaiswal1994
Copy link

@ysaucedo I tried in Calendarkit it doesnt seem possible. I was not able to get that view where I can create that dot.

So I used this library : https://github.com/WenchaoD/FSCalendar

With little bit customization it worked as the exact way what I need.

@MrCarter31
Copy link

Has anyone implemented this feature?

@richardtop
Copy link
Owner

@MrCarter31 no, feel free to propose a pull request implementing this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants