Removed dependency on DateToolsSwift #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #285 |
|
Hi, thanks a lot for this pull request. Removing DateTools has been definitely in the consideration.
Really good job and I'm looking forward to merging it as soon as those issues are fixed. |
|
There ya go.
… On Nov 14, 2020, at 12:59 PM, Richard Topchii ***@***.***> wrote:
Hi, thanks a lot for this pull request. Removing DateTools has been definitely in the consideration.
Overall it looks pretty good. Could you please add the following to your pull request:
Remove DateTools from the .podspec file, as to not to include this framework when installing with the CocoaPods
Rewrite sample apps to not use the DateTools. Currently, your pull request doesn't compile with the sample apps (because sample apps use DateTools).
To simplify the part 2 (rewrite of the apps), feel free to leave just the CustomCalendarExampleController and remove the ExampleController and the ExampleNotificationController.
Really good job and I'm looking forward to merging it as soon as those issues are fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#286 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACNEPWGZQCCE7Q6QNIG6TLSP3VU3ANCNFSM4TVNNSGA>.
|
richardtop
reviewed
Nov 15, 2020
| override func loadView() { | ||
| calendar = customCalendar | ||
| calendar.timeZone = TimeZone(identifier: "Europe/Paris")! |
There was a problem hiding this comment.
Could you please bring back the custom calendar implementation, as it shows how to launch CK and change something else but timezone. E.g. when a completely custom calendar is needed.
richardtop
reviewed
Nov 15, 2020
| @@ -124,24 +79,22 @@ class CustomCalendarExampleController: DayViewController, DatePickerControllerDe | |||
| } | |||
|
|
|||
| private func generateEventsForDate(_ date: Date) -> [EventDescriptor] { | |||
| var workingDate = date.add(TimeChunk.dateComponents(hours: Int(arc4random_uniform(10) + 5))) | |||
| var workingDate = Calendar.current.date(byAdding: .hour, value: Int.random(in: 1...15), to: date)! | |||
There was a problem hiding this comment.
Also, please use your custom calendar here, not the current one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to test this, but I removed the DateToolsSwift package and just used the standard methods Foundation provides. Most of the stuff that library was doing is pretty simple in the newer versions of Swift, so I think it's good to remove that dependency.
Happy to do more work on this.