Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when creating two techniques that default to each other #792

Closed
dec-00 opened this issue Jan 2, 2024 · 1 comment
Closed

Crash when creating two techniques that default to each other #792

dec-00 opened this issue Jan 2, 2024 · 1 comment
Labels

Comments

@dec-00
Copy link

dec-00 commented Jan 2, 2024

If you create two techniques in a character sheet, each defaulting to the other one, GCS will crash immediately.

For example, when creating a technique called "Broadsword" that defaults to "Shortsword", and a "Shortsword" technique that defaults to "Broadsword", GCS will crash as soon as you apply your changes to the latter technique.

Ideally, GCS should not allow the techniques to try to default to each other and instead give a warning for the mutual defaulting.

For most users, this crash would likely never occur unintentionally, but if a skill library was set up with many skill defaults as techniques (to support an uncommon house rule, see #791), then the user might accidentally add two mutually defaulting techniques to their sheet.

@richardwilkes
Copy link
Owner

Hmm... another thing that I didn't think ever happens in the official rules (techniques defaulting to other techniques), but I could be wrong. At any rate, again, techniques weren't considered when I wrote the safe-guards for skills, so I'll have to extend those to techniques here, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants