Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Category matching for Skill level and Weapon Damage bonuses #104

Closed
wants to merge 7 commits into from

Conversation

crnormand
Copy link
Contributor

@crnormand crnormand commented Jun 7, 2019

Looking at #81, I thought I could add a criteria to match against the categories. I was able to add it for Skill bonuses and Weapon Bonuses, but was uncertain how to handle Spell bonuses. I am uncertain what 'mMatchType' is, and how adding a category criteria would affect getKey() and the XML read/write methods. So i left that alone for the moment.

But it works for Skills (and techniques) and Weapons bonuses. You can make "quick" Talents for skills by selecting "whos name is anything" and "category is" and then entering a category (e.g. "Animal") and all skills with that category will gain the bonus.

You can also make a quick "Striking ST" kind of bonus by creating a WeaponBonus and set "whos required skill name is anything" and "category is" "Melee weapon". All melee weapons will now get the bonus damage.

Unfortunately, the OP requested the ability specifically for Spells... so I will continue to investigate.

Oh, and this seems to be directly on point for #35

@crnormand
Copy link
Contributor Author

This might also work for #46. You would have to add a particular category to the weapon, and then use this feature to only apply the weapon bonus to that category.

@crnormand crnormand closed this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant