Added Category matching for Skill level and Weapon Damage bonuses #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #81, I thought I could add a criteria to match against the categories. I was able to add it for Skill bonuses and Weapon Bonuses, but was uncertain how to handle Spell bonuses. I am uncertain what 'mMatchType' is, and how adding a category criteria would affect getKey() and the XML read/write methods. So i left that alone for the moment.
But it works for Skills (and techniques) and Weapons bonuses. You can make "quick" Talents for skills by selecting "whos name is anything" and "category is" and then entering a category (e.g. "Animal") and all skills with that category will gain the bonus.
You can also make a quick "Striking ST" kind of bonus by creating a WeaponBonus and set "whos required skill name is anything" and "category is" "Melee weapon". All melee weapons will now get the bonus damage.
Unfortunately, the OP requested the ability specifically for Spells... so I will continue to investigate.
Oh, and this seems to be directly on point for #35