Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantasy Folk - Goblins and Hobgoblins #267

Merged
merged 2 commits into from Jan 2, 2024

Conversation

ethorad
Copy link
Collaborator

@ethorad ethorad commented Jan 1, 2024

Added the traits and templates from the Fantasy Folk - Goblins and Hobgoblins book

Added the traits and templates from the Fantasy Folk - Goblins and Hobgoblins book
Copy link
Sponsor Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tidiness sake, I would put this in a subfolder under "Fantasy Folks".
Miscelleaneous notes:

  • Martial Art: Double Knife is missing a page reference
  • For your Martial Arts templates, I would utilise the template choice fields. You're welcome not to do this, but it would be helpful.
  • I would remove the file "Goblin Typical Traits". It seems unnecessary.
  • War-Beast "Attributes" trait container is missing "Attributes" container type.

@ethorad
Copy link
Collaborator Author

ethorad commented Jan 1, 2024

I didn't use the template choice groups for the Martial Art as I wanted to keep the traits and skills there for future reference.

With the choice approaach, you get one chance to select the traits and skills when you first apply the template. They are then gone and if you want to develop your character later you need to go back to check what the style components are.

With them all in the sheet in a group but disabled, then it acts as a reminder that you can easily turn on. If you want (e.g. if you know you're unlikely to take certain traits) then they can be deleted after applying the template.

I can convert them to use option groups though. Would set to "Choose any" and have separate groups for the core traits/skills and then another option group for the traits/skills which are actually optional for the style so it's clear to the user which are more essential.

What's the preference? I did see that the MA book doesn't seem to have any styles in there so I didn't have a template layout to copy

Moved to a subfolder under Fantasy Folk
Added page reference to Double-Knife style
(Also added "page highlight" fields on both styles to mean the right part gets highlighted on clicking the page number)
Removed the "Typical Goblin Traits" note
Added "Attributes" tag to the War-Beast attributes container

Haven't changed the styles to use the template choice fields per my other comment
@ethorad
Copy link
Collaborator Author

ethorad commented Jan 1, 2024

Made the changes (not sure if you got notified so thought I'd add a comment)

Copy link
Sponsor Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your justification for the way Martial Arts styles are done makes sense, and since there's no real precedent on format I guess we'll just go with it.

Approved.

@rinickolous rinickolous merged commit c722b7e into richardwilkes:master Jan 2, 2024
@ethorad ethorad deleted the FantasyFolk-Goblins branch January 4, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants