Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Druid.gct #276

Merged
merged 4 commits into from Jan 15, 2024
Merged

Update Druid.gct #276

merged 4 commits into from Jan 15, 2024

Conversation

daliin
Copy link
Sponsor Contributor

@daliin daliin commented Jan 13, 2024

DFRPG Druid template was lacking the two special skills, Esoteric Medicine (Druidic) and Herb Lore that appear at the end of the Druid template in DFRPG Adventurers (p. 23).

Copy link
Sponsor Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the container type of the 2 attribute containers to "Attributes". Other than that, no issues.

@daliin
Copy link
Sponsor Contributor Author

daliin commented Jan 13, 2024

Changed the two attribute containers to Attributes. Good catch.

Added missing disadvantages to the Norðlond Eldhuð racial template. Also updated page references and highlights to point to the right page of Nordlondr Folk.
@daliin
Copy link
Sponsor Contributor Author

daliin commented Jan 13, 2024

Hmm. Apparently I don't fully understand how pull requests work. I meant for the Eldhud racial template changes to be a separate thing, but they've apparently been lumped into the druid request.

@rinickolous rinickolous self-requested a review January 14, 2024 00:15
Copy link
Sponsor Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. If you could just remove the container saying "Can purchase up to Fire Resistance 15" from the Eldhuhd template as it's non-standard, then this will be approved. While I understand your intention with the container, we don't have consistency across other files with this at the moment.

@daliin
Copy link
Sponsor Contributor Author

daliin commented Jan 14, 2024

Thanks for the changes. If you could just remove the container saying "Can purchase up to Fire Resistance 15" from the Eldhuhd template as it's non-standard, then this will be approved. While I understand your intention with the container, we don't have consistency across other files with this at the moment.

Makes sense. I removed the container.

@rinickolous rinickolous merged commit 482496e into richardwilkes:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants