Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeFields property does not work for update operations. #103

Closed
ozanozen opened this issue Jul 17, 2013 · 1 comment
Closed

excludeFields property does not work for update operations. #103

ozanozen opened this issue Jul 17, 2013 · 1 comment

Comments

@ozanozen
Copy link
Contributor

This is my first time posting a bug to an open source project, I hope everything goes well.

I used this river for an existing db with exclusion filters and I observed that excluded fields did exist in the indexed documents. When I dug into the code I saw that for update operations the document is queried after exclusion step which rendered exclusion filter useless. I fixed the issue by moving the exclusion filter closer to adding the data to stream for operations other than update. For update I added a BasiDBObject to query which filters out excluded fields on db level.

I tested this fix intensively in our database (I didn't write new test cases due to time constraints I have in my project, sorry) and it works for multi level fields as well.

I will link the pull request

@richardwilly98
Copy link
Owner

PR #104 has been manually merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants